add the option to load env from a external secet #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyriosGN0
requested review from
BupycHuk and
idoqo
and removed request for
a team
|
I like it. @BupycHuk what do you think? |
BupycHuk
previously approved these changes
Oct 1, 2024
KyriosGN0
force-pushed
the
feat/pull-all-keys-from-existing-secret
branch
from
367f7ad
to
67423d9
Compare
|
@BupycHuk fixed conflicts, updated readme (although im not sure where should i have updated it) |
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
KyriosGN0
force-pushed
the
feat/pull-all-keys-from-existing-secret
branch
from
e39f97f
to
34c148d
Compare
Signed-off-by: AvivGuiser <[email protected]>
|
@BupycHuk possibly any updates here? |
BupycHuk
previously approved these changes
Oct 15, 2024
BupycHuk
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the reasom is that today, when using an existing secret, we can't put different values from the ones that are in the created secret.
this will allow users to use an external secret (for example with external-secrets operator) and put any required variables as env vars